Skip to content

Call update even if the settings fetch fails #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Call update even if the settings fetch fails #390

merged 1 commit into from
Jun 23, 2025

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Jun 23, 2025

  • Call update on plugins even if the settings fetch fails.

@bsneed bsneed merged commit 499a67c into main Jun 23, 2025
8 of 9 checks passed
@bsneed bsneed deleted the bsneed/update branch June 23, 2025 21:15
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.06%. Comparing base (55127ac) to head (2c78301).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Segment/Settings.swift 7.69% 12 Missing ⚠️

❌ Your patch status has failed because the patch coverage (7.69%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   70.23%   70.06%   -0.18%     
==========================================
  Files          48       48              
  Lines        4795     4797       +2     
==========================================
- Hits         3368     3361       -7     
- Misses       1427     1436       +9
Files with missing lines Coverage Δ
Sources/Segment/Settings.swift 57.93% <7.69%> (-0.82%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didiergarcia didiergarcia didiergarcia approved these changes

@wenxi-zeng wenxi-zeng wenxi-zeng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bsneed @didiergarcia @wenxi-zeng